Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Qt style names in a case insensitive way #21720

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Oct 30, 2024

Closes #21716.

@glassez glassez added the GUI GUI-related issues/changes label Oct 30, 2024
@glassez glassez added this to the 5.0.2 milestone Oct 30, 2024
@glassez glassez requested a review from a team October 30, 2024 16:00
xavier2k6
xavier2k6 previously approved these changes Oct 30, 2024
@xavier2k6
Copy link
Member

@stalkerok please test too.

Copy link
Contributor

@stalkerok stalkerok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

sledgehammer999
sledgehammer999 previously approved these changes Nov 1, 2024
Copy link
Member

@sledgehammer999 sledgehammer999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks straight forward.
I approve since the bug reporter confirms that it fixes the problem.

src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
src/gui/optionsdialog.cpp Outdated Show resolved Hide resolved
@sledgehammer999
Copy link
Member

@stalkerok can you confirm that the new patch works too?

@xavier2k6
Copy link
Member

Re-tested & 👍

@stalkerok
Copy link
Contributor

Re-tested 👍

@glassez glassez merged commit b083029 into qbittorrent:master Nov 3, 2024
14 checks passed
@glassez glassez deleted the fix-style-option branch November 3, 2024 06:55
glassez added a commit to glassez/qBittorrent that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System style (Fusion) switches to windowsvista after changing any setting
5 participants