Proportional Uneven Inference Sharding #2734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 10, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
04276ed to
592be51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
force-pushed
the
export-D69057627
branch
from
592be51 to
6dff1b2
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 13, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Differential Revision: D69057627
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 13, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
6dff1b2 to
a5746a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 13, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
a5746a8 to
1b6932d
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 13, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
1b6932d to
a5354b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 14, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
a5354b7 to
dde07fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Feb 14, 2025
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Reviewed By: dstaay-fb, emlin Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
dde07fb to
bbaf561
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
Summary: Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training. A "best effort" sharding is performed across bucket boundaries proportional to memory list. * Added bucketization awareness to RW sharding, * TGIF sharding now ensures at most 1 bucket difference across equal memory uneven shards as opposed to previous logic of remainder rows to last shard * InferRWSparseDist checks for customized embedding_shard_metadata for uneven shards before dividing evenly Reviewed By: dstaay-fb, emlin Differential Revision: D69057627
kausv
force-pushed
the
export-D69057627
branch
from
bbaf561 to
5dc452f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69057627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support bucketization aware inference sharding in TGIF for ZCH bucket boundaries from training.
A "best effort" sharding is performed across bucket boundaries proportional to memory list.
Differential Revision: D69057627