Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make quantize_.set_inductor_config None by default #1716

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 14, 2025

…tion

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user specified this argument or not. After this PR, we can control the behavior per-workflow, such as setting this functionality to False for future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

@vkuzo vkuzo added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Feb 14, 2025
Copy link

pytorch-bot bot commented Feb 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1716

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bcf77e5 with merge base 12e830b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2025
@vkuzo vkuzo force-pushed the 20250214_quantize_inductor_config branch from e84f67a to 691ffb7 Compare February 14, 2025 16:57
…tion

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user
specified this argument or not.  After this PR, we can control the
behavior per-workflow, such as setting this functionality to False for
future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
@vkuzo vkuzo force-pushed the 20250214_quantize_inductor_config branch from 691ffb7 to bcf77e5 Compare February 14, 2025 16:58
@vkuzo vkuzo merged commit 3227472 into main Feb 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants