Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new signing tool for Windows releases #190

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Switch to new signing tool for Windows releases #190

merged 7 commits into from
Nov 11, 2024

Conversation

zooba
Copy link
Member

@zooba zooba commented Nov 7, 2024

The dotnet sign tool is capable of signing all our file types that we need using Trusted Signing, which should simplify our use of it.

@zooba
Copy link
Member Author

zooba commented Nov 8, 2024

We can't swap over yet due to a few more Nuget-related limitations.

@zooba
Copy link
Member Author

zooba commented Nov 8, 2024

It may not be a limitation - Nuget doesn't like signing with the lifetime signing EKU1 attached to the test cert. So it's possible that real signing will work fine. I'm following up with the relevant teams to see what the best approach here is.

We still don't have to hurry to merge this change. Nuget.org doesn't validate Azure Trusted Signing signatures yet anyway.

Footnotes

  1. A marker to indicate that signatures shouldn't be trusted beyond the lifetime of the certificate, even if timestamped.

@zooba zooba marked this pull request as ready for review November 8, 2024 17:21
@zooba
Copy link
Member Author

zooba commented Nov 8, 2024

Signing works fine with the real certificate (tested, but deleted the test build to avoid having extra signed builds of Python floating around). So this is okay to merge.

@sethmlarson, don't suppose you're interested in taking a look? (Feel free to hit merge if you like, I have nothing more to do here)

@zooba zooba merged commit 6ec0cb7 into master Nov 11, 2024
15 checks passed
@zooba zooba deleted the nugetsign branch November 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant