Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activate.nu to support Linux and MacOS #2831

Closed
wants to merge 3 commits into from

Conversation

tobiasborregaard
Copy link

@tobiasborregaard tobiasborregaard commented Jan 22, 2025

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Changes Introduced

  1. Cross-Platform Compatibility:

    • Added detection of Windows, Linux, and macOS using $nu.os-info.name.
    • Dynamically adjusts environment settings based on OS (e.g., binary folder, path separators).
  2. Improved Path Handling:

    • Dynamic detection and handling of PATH for Windows (Path) vs Unix (PATH).
    • Ensured compatibility by adding correct path separators (; for Windows, : for Linux/macOS).
  3. Prompt Handling:

    • Improved prompt management to reflect the active virtual environment.
    • Preserved previous prompt states for better user experience.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please.

Please also describe what changes it introduces exactly becuase we already support those platforms (see CI run and test suite).

@gaborbernat gaborbernat marked this pull request as draft January 22, 2025 17:05
@tobiasborregaard tobiasborregaard marked this pull request as ready for review January 22, 2025 17:32
@gaborbernat
Copy link
Contributor

gaborbernat commented Jan 24, 2025

@tobiasborregaard tobiasborregaard marked this pull request as ready for review 2 days ago

Please don't do that. I requested changes and this is in draft until you address them, plus the CI is failing. This PR is not ready for review at all.

@gaborbernat gaborbernat marked this pull request as draft January 24, 2025 16:04
@tobiasborregaard
Copy link
Author

I have addressed the reason why the test suite was failing, i am unsure what more you want? @gaborbernat

i couldnt get virtualenv to run on debian, and this adressed the issues aswell

@gaborbernat
Copy link
Contributor

Changelog please.

Please also describe what changes it introduces exactly becuase we already support those platforms (see CI run and test suite).

👍

@tobiasborregaard tobiasborregaard deleted the patch-1 branch January 24, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants