Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow user to skip validation of pyproject.toml via env var" #4746

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

abravalheri
Copy link
Contributor

This reverts commit 913d50a.

Summary of changes

Related to the discussions in #4459.

Pull Request Checklist

@mgorny
Copy link
Contributor

mgorny commented Nov 13, 2024

To be honest, if I were to use it, it would be of pure spite, to have users witness this verbose warning on every package they install and be confused by it, and keep filing bugs, with the hope that they'd eventually bother enough people that they'd put enough pressure on setuptools to do the right thing. But I don't want to be that kind of person, so feel free to remove it.

@abravalheri abravalheri merged commit 57ed6f0 into pypa:main Nov 13, 2024
24 checks passed
@abravalheri abravalheri deleted the revert-4611 branch November 13, 2024 10:51
@abravalheri
Copy link
Contributor Author

Thank you very much for confirming @mgorny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants