Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimum requirement for jaraco.functools #4666

Conversation

anderstheet
Copy link
Contributor

Summary of changes

Adds a minimum requirement to jaraco.functools

Closes #4665

@@ -103,7 +103,7 @@ core = [

# for distutils
"jaraco.collections",
"jaraco.functools",
"jaraco.functools>=4",
Copy link
Contributor

@Avasam Avasam Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be changed there too: https://github.com/pypa/distutils/blob/378984e02edae91d5f49425da8436f8dd9152b8a/pyproject.toml#L23

Since that repo is where the vendored distutils (and hence, these deps) is coming from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that what this changes? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, any change done in the _distutils folder should be done in the distutils repo instead.

I'm just not sure if pyproject dependencies follow the same rule (ie: are they refreshed from distutils or are they manually updated). So you could do the same change over there.

Anyway, maintainers will let you if that's the case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh makes sense.

I have created a pull request in the distutils repo 👍
pypa/distutils#301

@abravalheri abravalheri merged commit 8d518af into pypa:main Nov 11, 2024
2 checks passed
@abravalheri
Copy link
Contributor

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Minimum requirement for jaraco.functools
4 participants