Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for pathlib paths in build_base #4630

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Restore support for pathlib paths in build_base #4630

merged 8 commits into from
Sep 3, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 3, 2024

  • In sdist.prune_file_list, support build.build_base as a pathlib.Path.
  • Add test capturing missed expectation.
  • Enable the test
  • Add news fragment.

Merges incidental changes in distutils:

Summary of changes

Closes #4615

Pull Request Checklist

Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Jason!

setuptools/tests/test_sdist.py Show resolved Hide resolved
@jaraco jaraco merged commit d8933c5 into main Sep 3, 2024
42 checks passed
@jaraco jaraco deleted the bugfix/4615 branch September 3, 2024 23:01
@jaraco
Copy link
Member Author

jaraco commented Sep 4, 2024

These tests passed on pypy here, but failed on the release job (https://github.com/pypa/setuptools/actions/runs/10692324985).

@jaraco jaraco mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some packages still needing setup.py fail to build in 74.0.0
2 participants