Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/installer/utils.py: sort entries before writing out RECORD file #245

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kanavin
Copy link
Contributor

@kanavin kanavin commented Oct 15, 2024

This helps build reproducibility by ensuring the RECORD file is the same regardless of the order of the input files.

This helps build reproducibility by ensuring the RECORD file
is the same regardless of the order of the input files.
@eli-schwartz
Copy link
Contributor

Note that it is wiser to delete the RECORD file anyway since you do not want to indicate to pip that it knows how to uninstall projects it didn't install and which are tracked by a more comprehensive installation database.

(Plans for pip to respect an INSTALLER identity fell through, unfortunately.)

@rossburton
Copy link

@eli-schwartz I like that argument. Can you point at prior art in eg gentoo as a rationale for doing it distro-wide?

@rossburton
Copy link

(and if that's a generally accepted point of view, maybe installer should have an option to not write them for the case where we don't expect anything to remove the packages?)

@rossburton
Copy link

Either way though, reproducible files are good.

@eli-schwartz
Copy link
Contributor

@eli-schwartz
Copy link
Contributor

Note that it is wiser to delete the RECORD file anyway

This is a typo, it should be "it is wise to delete [...] anyway" -- the word "wiser" would imply that this PR should be avoided and replaced by deletion but that wasn't what I was trying to write. :)

@Secrus Secrus merged commit a86f4f7 into pypa:main Oct 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants