-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removed importlib.resources.read_binary
in Python 3.13
#201
Fix removed importlib.resources.read_binary
in Python 3.13
#201
Conversation
@pradyunsg this is ready for review 🙂 |
Please clean up your PR. There are a lot of changes that don't seem to be related to what the title and linked issue mention (especially around |
cbf1b6c
to
7c5e7a4
Compare
Thanks @Secrus. I've limited the diff to
|
It's rather difficult to tell what you've limited to, or why you kept in the diffs you did, since they are divided up between 7 different commits that are mostly reverting previous commits. 🤔 on the other hand it appears quite likely all context will be lost due to squash merging anyway. |
@edgarrmondragon thank you for your contribution. I would love to see other changes you previously made in this PR, so feel free to open PRs with those 😉 |
Extracted from pypa#201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Extracted from pypa#201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Extracted from pypa#201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Extracted from pypa#201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Wait for new release of pypa/installer greater than 0.7.0 who have MR pypa/installer#201
Wait for new release of pypa/installer greater than 0.7.0 who have MR pypa/installer#201
Extracted from pypa#201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Extracted from #201 to make a cleaner diff. References: * https://pyproject-fmt.readthedocs.io/en/latest/
Closes #132