Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removed importlib.resources.read_binary in Python 3.13 #201

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

edgarrmondragon
Copy link
Contributor

Closes #132

@edgarrmondragon
Copy link
Contributor Author

@pradyunsg this is ready for review 🙂

@Secrus
Copy link
Member

Secrus commented Dec 17, 2023

Please clean up your PR. There are a lot of changes that don't seem to be related to what the title and linked issue mention (especially around pyproject.toml file).

@edgarrmondragon
Copy link
Contributor Author

Please clean up your PR. There are a lot of changes that don't seem to be related to what the title and linked issue mention (especially around pyproject.toml file).

Thanks @Secrus. I've limited the diff to

  • noxfile.py: adds 3.12 and 3.13
  • workflow: updates the matrix and bumps actions/setup-python so we can use allow-prereleases

@eli-schwartz
Copy link
Contributor

It's rather difficult to tell what you've limited to, or why you kept in the diffs you did, since they are divided up between 7 different commits that are mostly reverting previous commits.

🤔 on the other hand it appears quite likely all context will be lost due to squash merging anyway.

@Secrus Secrus merged commit b23f89b into pypa:main Dec 19, 2023
24 checks passed
@Secrus
Copy link
Member

Secrus commented Dec 19, 2023

@edgarrmondragon thank you for your contribution. I would love to see other changes you previously made in this PR, so feel free to open PRs with those 😉

@edgarrmondragon edgarrmondragon deleted the importlib.resources.read_binary branch December 21, 2023 01:20
edgarrmondragon added a commit to edgarrmondragon/installer that referenced this pull request Dec 21, 2023
edgarrmondragon added a commit to edgarrmondragon/installer that referenced this pull request Dec 22, 2023
edgarrmondragon added a commit to edgarrmondragon/installer that referenced this pull request Dec 22, 2023
edgarrmondragon added a commit to edgarrmondragon/installer that referenced this pull request Dec 22, 2023
LeMyst added a commit to LeMyst/WikibaseIntegrator that referenced this pull request Jan 8, 2024
Wait for new release of pypa/installer greater than 0.7.0 who have MR pypa/installer#201
LeMyst added a commit to LeMyst/WikibaseIntegrator that referenced this pull request Jan 8, 2024
Wait for new release of pypa/installer greater than 0.7.0 who have MR pypa/installer#201
edgarrmondragon added a commit to edgarrmondragon/installer that referenced this pull request Jan 11, 2024
Secrus pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts.py utilizes the deprecated read_binary function from importlib.resources.
3 participants