-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _vendor
directory
#288
Conversation
The diffcov errors are weird, probably there due to the broken main brought about by a nitpicky change in ruff import sorting, which is now fixed in 7ee6a6e. |
Thank you very much for the review and improvements @jaraco.
There is another approach as well which is to "just let setuptools do its thing" and remove this concern from In the future we either start moving code from setuptools to distutils to remove the need for patching, or add a method that allows using Footnotes
|
Setuptools recently changed its vendoring method to address the criticism regarding the proliferation of
_vendor
directories and multiple copies of the same files being distributed in the same wheel/sdist: pypa/setuptools#4455.That change however do not address the existence of
setuptools/_distutils/_vendor
and therefore do not close the original issue 100%. I think there is not much point indistutils
maintaining its own vendoring system, so this PR proposes simply removing it, and relying on the dependencies that come installed with setuptools.In pypa/setuptools#4594, we also got a report regarding external tools expecting
setuptools/_distutils/_vendor/*.dist-info
folders to behave in a certain way (despite it being a private directory and not added tosys.path
). Although that issue is not really a bug in setuptools (in my opinion), simply removingdistutils/_vendor
would also help with that.