Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy msvc compiler modules. #287

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Remove legacy msvc compiler modules. #287

merged 2 commits into from
Aug 27, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 27, 2024

They were marked as deprecated in c802880, so they shouldn't be in use.

@jaraco jaraco merged commit 23e3bfa into main Aug 27, 2024
42 checks passed
@jaraco jaraco deleted the debt/remove-legacy-msvc branch August 27, 2024 07:08
@alex
Copy link
Member

alex commented Aug 27, 2024

Notwithstanding that these shouldn't be in use, in practice these appear to be used by cffi, and thus this change breaks cffi: https://github.com/python-cffi/cffi/blob/main/src/cffi/_shimmed_dist_utils.py#L33

I'll file a cffi bug about fixing this.

@eli-schwartz
Copy link

@illume
Copy link

illume commented Sep 1, 2024

broke pygame

@jaraco
Copy link
Member Author

jaraco commented Sep 1, 2024

broke pygame

If you have a reference to the downstream report, that would be helpful to follow. I looked briefly into the other issues and I don't think there's anything this project should do, though I could consider re-adding some interfaces to restore compatibility for a limited duration, but only if there's a compelling case. In general, I expect users reliant on these older modules to be in a precarious state anyhow.

@illume
Copy link

illume commented Sep 3, 2024

For pygame the setuptools for windows msvc compilers have been pinned to previous setuptools version. I haven't looked yet on how to update the code which uses the compiler yet. It's here if you're interested: https://github.com/pygame/pygame/blob/main/buildconfig/vstools.py

I know not everyone can pin their packages to previous versions of setuptools. But for anyone that can pin whilst they fix, I wrote instructions here: pypa/setuptools#4620 (comment)

@nitzmahone
Copy link

nitzmahone commented Sep 4, 2024

Looks like the cffi "usage" is an ancient and mostly-dead monkeypatch- spinning an updated CFFI release now that makes the import/patch optional until we're sure it's "all dead" and can go through its pockets for loose change 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants