Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types - dns: add a new dns type with more specific fqdn definitions #1347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on May 3, 2023

  1. types - dns: add a new dns type with more specific fqdn definitions

    This PR introduces a new set of types for validating FQDN's.  it creates
    a type for the more loose rfc definitions of domain names and a stricter
    and likely more useful iana type.
    
    This allows us to create a new type that more does to what most users
    expect i.e. that a dns name is one that works on the internt, without
    breaking current uses for users that may be using the Stdlib::Fqdn to
    validate validate DNS names that don't work with the IANA roots.
    
    The intention of this patch would be to deprecate the currnet Stdlib::Fqdn
    type and encourage users to move to the appropriate Stdlib::DNS::* type
    which for most users will likely be the stricter Stdlib::DNS::Fqdn type
    
    Note: this PR is intentionally a bit rough to first garner thoughts as to
    if this is the correct direction
    
    Fixes puppetlabs#1282 (not sure it fixes but want it tagged)
    b4ldr committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5a02c3e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Update types/fqdn.pp

    Co-authored-by: Jonas Verhofsté <[email protected]>
    b4ldr and JonasVerhofste authored May 29, 2023
    Configuration menu
    Copy the full SHA
    b4a8c2a View commit details
    Browse the repository at this point in the history