Update log_error default for recent Debian/Ubuntu
#1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mariadb-server packages now skip the creation of /var/log/mysql during installation see commit: https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/ee379fcbdc363b42efa042c4225ed158fe184c02?merge_request_iid=27
jcharaoui
requested review from
alexjfisher,
bastelfreak and
a team
as code owners
bastelfreak
reviewed
Feb 24, 2024
| @@ -187,6 +186,14 @@ | |||
| $tmpdir = '/tmp' | |||
| $managed_dirs = ['tmpdir','basedir','datadir','innodb_data_home_dir','innodb_log_group_home_dir','innodb_undo_directory','innodb_tmpdir'] | |||
|
|
|||
| # log_error base directory absent in Debian >= 12 | |||
| if ($facts['os']['name'] == 'Debian' and versioncmp($facts['os']['release']['full'], '12') >= 0) or | |||
There was a problem hiding this comment.
Would it make sense to check for the mariadb version and not the OS version? Or is that a Debian specific change?
There was a problem hiding this comment.
That really is a packaging-specific change. The directory used to be created in the package's "postinst" maintainer script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mariadb-server packages now skips the creation of
/var/log/mysqlduring installation.see commit: https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/ee379fcbdc363b42efa042c4225ed158fe184c02?merge_request_iid=27
Without this patch, with default settings, the database server encounters a startup failure.