Remove duplicate name key from Accounts::User::Resource #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kenyon
added a commit
to kenyon/puppet
that referenced
this pull request
Mar 1, 2024
|
@apcheamitru - Any chance you could resolve the email address and CLA requirements so this can get merged? |
bastelfreak
approved these changes
Mar 9, 2024
apcheamitru
force-pushed
the
bugfix/475-duplicate-name
branch
from
61bf9f6
to
58cad06
Compare
Signed-off-by: Alex Cheamitru <[email protected]>
Signed-off-by: Alex Cheamitru <[email protected]>
apcheamitru
force-pushed
the
bugfix/475-duplicate-name
branch
from
58cad06
to
dec3c32
Compare
jhoblitt
added a commit
to lsst-it/puppet-ccs_software
that referenced
this pull request
Mar 19, 2024
because the accpetance tests are failing under puppet8 because of this bug: puppetlabs/puppetlabs-accounts#476
Orest-Worhacz
approved these changes
Mar 20, 2024
|
Until the PR is merged I use: |
bastelfreak
reviewed
Mar 24, 2024
| @@ -18,7 +18,6 @@ | |||
| Optional[gid] => Accounts::User::Uid, | |||
| Optional[group] => Accounts::User::Name, | |||
| Optional[groups] => Array[Accounts::User::Name], | |||
| Optional[name] => Accounts::User::Name, | |||
There was a problem hiding this comment.
is that actually a duplicate? I don't see it again
There was a problem hiding this comment.
During the time it took to get this PR approved, someone else made a commit that removed the duplicate entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicate name key from
Accounts::User::Resourcetype.Related Issues (if any)
#475
Checklist
puppet apply)