feature/MV 1829 Use OpenEB Dockerfile to build and test on GitHubActions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
18 times, most recently
from
66de3f5
to
c169b44
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
c169b44
to
4e26156
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
6 times, most recently
from
da87657
to
3d90ee5
Compare
.github/workflows/all_jobs.yaml
Outdated
| context: | ||
| file: .github/workflows/Dockerfile.OpenEB | ||
| push: true | ||
| tags: prophesee/openeb:openeb-ubuntu-20.04 |
There was a problem hiding this comment.
Why not just this ?
Suggested change
| tags: prophesee/openeb:openeb-ubuntu-20.04 | |
| tags: prophesee/openeb:ubuntu-20.04 |
There was a problem hiding this comment.
Look at this link : https://hub.docker.com/repository/docker/prophesee/openeb/tags?page=1&ordering=last_updated
The first image is the one that I use and the second one is the suggestion that you put, and you will understand that if we don't specify openeb here we won't know the version of openeb. We know that we are in prophesee/openeb thanks to the repository, but the image will be called only ubuntu-20.04. I want the image to be called openeb-ubuntu-20.04 so we know we are talking about the openeb image
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
3d90ee5
to
c687142
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
c687142
to
2d1abf3
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
2d1abf3
to
0cae898
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
449f221
to
cbfaf4f
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
cbfaf4f
to
34954a5
Compare
esecondy-psee
force-pushed
the
feature/MV-1829-Use-OpenEB-dockerfile-to-build-&-test-on-GitHubAction
branch
from
c05bc73
to
3cc7935
Compare
lbristiel-psee
approved these changes
Feb 9, 2024
ogeorget-psee
requested changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.