Initial port of SlippiDirectCodes to Rust #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the direct codes parsing/loading/vending from C++ to Rust. Where applicable, certain things that weren't in use in the C++ version - but may be useful in the future - were also ported but commented out. The only significant change here is that this changes the `lastPlayed` field in codes files to be a unix timestamp rather than a datetimestamp that requires a full parser. There's fallback code in the parser to handle the older format, though; subsequent writes will just write unix timestamps to the file instead. This entire bit should be transparent to users and is purely a convenience thing. This also makes a change to the public interface of the Rust lib: rather than passing over a fully qualified `user.json` path, we now just pass the folder where it's found and then build paths on the Rust side - since we need to do this for direct code file paths anyway.
…that c/cpp do not complain incessantly about overrides
It looks like the mainline build might use different cased keys, so adding an alias here so they all centralize and the lib can work across builds.
…t-extensions into port/direct-codes * 'port/direct-codes' of github.com:ryanmcgrath/slippi-rust-extensions: Tweak cbindgen to guard itself a bit more, alter an FFI enum name so that c/cpp do not complain incessantly about overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the direct codes parsing/loading/vending from C++ to Rust. Where applicable, certain things that weren't in use in the C++ version - but may be useful in the future - were also ported but commented out.
The only significant change here is that this changes the
lastPlayedfield in codes files to be a unix timestamp rather than a datetimestamp that requires a full parser. There's fallback code in the parser to handle the older format, though; subsequent writes will just write unix timestamps to the file instead. This entire bit should be transparent to users and is purely a convenience thing.This also makes a change to the public interface of the Rust lib: rather than passing over a fully qualified
user.jsonpath, we now just pass the folder where it's found and then build paths on the Rust side - since we need to do this for direct code file paths anyway.