Init of Discord Rich Presence for Slippi #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAndersMadsen
commented
Jan 29, 2024
TheAndersMadsen
commented
- Currently not working
- Currently not working
Removing tokio (partly done) (untested)
The core code was temporarily moved into `discord-rpc/src/bin.rs`, and a new `discord-rpc/src/lib.rs` now exists which stubs out the general flow of how the "handle" should work. This will compile cleanly and "run", albeit do nothing - but now the Discord work that Anders has done can be layered in. This removed a few dependencies from `discord-rpc` that caused compilation issues on non-Windows-x86-64 machines (e.g, windows, tray, ruspiro-singleton). The approach this lib has to take to integrate with Dolphin also likely means we won't need these, but I wanted to make a note to be safe. No actual core logic of the feature has been touched.
… will also use it in the discord handler
This part might change but it makes some development pieces easier at the moment.
Making jukebox the foundation for the discord rpc
This data is only accessible after both the EXI device and the memory subsystem have initialized, so there's now a new callback that is notified after initialization of both has completed. This callback is also where the Discord handler is launched; there may still be ongoing work here regarding preferences/launching/etc, so WIP. This also corrects the log name to match the one in the Ishiiruka repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.