Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump AppWrapper to 1.0.0 #652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bump AppWrapper to 1.0.0 #652

wants to merge 2 commits into from

Conversation

dgrove-oss
Copy link
Collaborator

  • Update to Kueue 0.10
  • Remove deprecated kube-rbac-proxy
  • Refactor workload controller to prepare to upstream to Kueue

Combines go.mod changes of #651 with the Makefile change to pick up the CRD.

@dgrove-oss
bump AppWrapper to 1.0.0
699f898 
+ Update to Kueue 0.10
+ Remove deprecated kube-rbac-proxy
+ Refactor workload controller to prepare to upstream to Kueue
@openshift-ci openshift-ci bot requested review from astefanutti and dimakis January 16, 2025 18:55
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christianzaccaria for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ChristianZaccaria
ChristianZaccaria reviewed Jan 16, 2025
View reviewed changes
go.mod

replace sigs.k8s.io/custom-metrics-apiserver => sigs.k8s.io/custom-metrics-apiserver v1.25.1-0.20230306170449-63d8c93851f3

replace go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0

replace github.com/jackc/pgx/v4 => github.com/jackc/pgx/v5 v5.5.4

// This replace directive deal with the backlevel ODH kueue version
replace sigs.k8s.io/kueue v0.8.3 => github.com/opendatahub-io/kueue v0.8.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this as:

replace sigs.k8s.io/kueue v0.10.0 => github.com/opendatahub-io/kueue v0.10.0-odh

@ChristianZaccaria
Copy link
Contributor

Perhaps the Makefile can also be updated to use Kueue v0.10.0

@ChristianZaccaria
Copy link
Contributor

I'm getting this error on attempt to create AppWrapper, in the CFO logs:

2025-01-16T20:51:21Z ERROR Unhandled Error {"logger": "UnhandledError", "error": "pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.Namespace: failed to list *v1.Namespace: namespaces is forbidden: User "system:serviceaccount:redhat-ods-applications:codeflare-operator-controller-manager" cannot list resource "namespaces" in API group "" at the cluster scope"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianZaccaria ChristianZaccaria ChristianZaccaria left review comments

@astefanutti astefanutti Awaiting requested review from astefanutti

@dimakis dimakis Awaiting requested review from dimakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgrove-oss @ChristianZaccaria