Skip to content

Commit

Permalink
use standalone configuration/tests for devmode tests for CI (#309)
Browse files Browse the repository at this point in the history
we're not faking the kueue webhook in the controller, so the devmode
tests need to be changed to standalone (no kueue)
  • Loading branch information
dgrove-oss authored Feb 5, 2025
1 parent f3793e2 commit 782f7ea
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/CI-devmode.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ jobs:
- name: Create and configure cluster
run: ./hack/create-test-cluster.sh

- name: Deploy Kueue
run: ./hack/deploy-kueue.sh

- name: Install CRDs
run: |
make install -e GIT_BRANCH=${{ env.GIT_BRANCH }} TAG=${{ env.GIT_BRANCH }}-${{ env.TAG }}
Expand Down
2 changes: 1 addition & 1 deletion config/dev/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
data:
config.yaml: |
appwrapper:
enableKueueIntegrations: true
enableKueueIntegrations: false
controllerManager:
health:
bindAddress: "localhost:0"
Expand Down
3 changes: 1 addition & 2 deletions docs/release_instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ will:
+ create a [GitHub release](https://github.com/project-codeflare/appwrapper/releases) that contains the install.yaml

4. Update the kustomization.yaml files in MLBatch to refer to the new release:
+ setup.k8s-v1.27/appwrapper/kustomization.yaml
+ setup.k8s-v1.30/appwrapper/kustomization.yaml
+ setup.k8s/appwrapper/kustomization.yaml

4. To workaround back level go versions in ODH, we also maintain a
codeflare-releases branch. After making a release, merge main
Expand Down
2 changes: 1 addition & 1 deletion hack/run-dev-mode-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ run () {
}

NAMESPACE=dev go run ./cmd/main.go &
run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Kueue ./test/e2e
run $! go run github.com/onsi/ginkgo/v2/ginkgo -v -fail-fast --procs 1 -timeout 130m --label-filter=Standalone ./test/e2e

RC=$?
if [ ${RC} -eq 0 ]
Expand Down

0 comments on commit 782f7ea

Please sign in to comment.