Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build tags #680

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix build tags #680

merged 2 commits into from
Nov 16, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
Because a single fix PR wasn't enough, here comes the second (and hopefully last) fix to build system for now.

It fixes:

  • The missing "v" before version strings in container tags
  • The typo in docker buildx imagetools command (missing "s")
  • Remove -handler suffix from discovery-handlers' container name

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@diconico07
Fix remaining tag issues
510df19 
This fixes the remaining container tag issues:
 - Missing "v" before version string
 - Typo in docker buildx imagetools command (missing "s" to imagetools)
 - Remove "-handler" suffix to container names for discovery handlers

Signed-off-by: Nicolas Belouin <[email protected]>
@diconico07
Update patch version
062c3ac 
Signed-off-by: Nicolas Belouin <[email protected]>
@diconico07 diconico07 merged commit 9fe0150 into project-akri:main Nov 16, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonshih johnsonshih johnsonshih approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring kate-goldenring is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diconico07 @johnsonshih