Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authenticated access to Onvif devices #646

Merged

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Aug 12, 2023

What this PR does / why we need it:
refs #250
This PR enables the broker to access Onvif devices with username/password. The broker uses device uuid to look up credential from credential directories and authenticate the device access using the credential found.

The schema of credentials in credential directories is described in project-akri/akri-docs#78

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@bfjelds
Copy link
Collaborator

bfjelds commented Aug 18, 2023

is there a docs PR? i see the proposal PR, but i'm wondering about some user docs that explain how to use this.

Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih
Copy link
Contributor Author

is there a docs PR? i see the proposal PR, but i'm wondering about some user docs that explain how to use this.

yes, there will be some follow up PRs to update Onvif DH document for newly added uuid filter, optional ip/mac address filter and secret information usage.

Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih
Copy link
Contributor Author

is there a docs PR? i see the proposal PR, but i'm wondering about some user docs that explain how to use this.

yes, there will be some follow up PRs to update Onvif DH document for newly added uuid filter, optional ip/mac address filter and secret information usage.

The docs PR for the secret usage: project-akri/akri-docs#90

@johnsonshih johnsonshih merged commit 209d7df into project-akri:main Sep 7, 2023
26 of 38 checks passed
@johnsonshih johnsonshih deleted the user/jshih/onvif-broker-auth-pr branch September 7, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants