Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read cooldown to allow card removal in Chameleon module #780

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

bruno-1337
Copy link
Contributor

Proposed Changes

Added a 2-second cooldown period after successful card reads in Chameleon module to prevent immediate re-reading. This gives users time to remove the card from the Chameleon Ultra device before subsequent read attempts.

Types of Changes

  • Bugfix (addresses unintended immediate re-read behavior)
  • Hardware interaction improvement

Linked Issues

Fixes #739

Copy link
Collaborator

@rennancockles rennancockles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same bug happens when reading tags using the module boards like RFID2 and pn532. You could apply the same fix to the TagOMatic::read_card() method in the tag_o_matic.cpp file.

Copy link
Collaborator

@rennancockles rennancockles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you were supposed to keep the chameleon code as well as it’s a different application. Same fix in both places

@bruno-1337
Copy link
Contributor Author

k now we good

@pr3y pr3y merged commit a70e1ab into pr3y:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chameleon ultra needs delay
3 participants