Improved prop types

ponymessenger · Aug 30, 2020 · c48da2a · c48da2a
1 parent 76877f8
commit c48da2a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "use-prosemirror",
-    "version": "1.1.4",
+    "version": "1.1.5",
     "description": "ProseMirror for React",
     "main": "./dist/index.js",
     "types": "./dist/index.d.ts",

diff --git a/src/ProseMirror.tsx b/src/ProseMirror.tsx
@@ -5,25 +5,27 @@ import React, {
     forwardRef,
     CSSProperties,
 } from 'react';
-import {EditorView, DirectEditorProps} from 'prosemirror-view';
+import {
+    EditorView,
+    EditorProps,
+    DirectEditorProps,
+} from 'prosemirror-view';
 import {EditorState} from 'prosemirror-state';
 import {Schema} from 'prosemirror-model';
 
 export interface Handle {
     view: EditorView;
 }
 
-interface Props<S extends Schema = any>
-    extends Partial<DirectEditorProps<S>> {
+interface Props<S extends Schema = any> extends EditorProps<S> {
     state: EditorState<S>;
     onChange: (state: EditorState) => void;
     style?: CSSProperties;
     className?: string;
 }
 
 export default forwardRef<Handle, Props>(function ProseMirror(
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    {dispatchTransaction, onChange, style, className, ...props},
+    {onChange, style, className, ...props},
     ref,
 ): JSX.Element {
     const root = useRef<HTMLDivElement>(null!);
@@ -48,7 +50,10 @@ export default forwardRef<Handle, Props>(function ProseMirror(
         },
     }));
     return <div ref={root} style={style} className={className} />;
-    function buildProps(props: DirectEditorProps): DirectEditorProps {
+
+    function buildProps(
+        props: Omit<DirectEditorProps, 'dispatchTransaction'>,
+    ): DirectEditorProps {
         return {
             ...props,
             dispatchTransaction: transaction => {