Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add CONTRIBUTING.md #1043

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 25, 2025

Summary

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 1:57pm

Copy link

codesandbox-ci bot commented Jan 25, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1043

commit: a867344

CONTRIBUTING.md Outdated
Comment on lines 72 to 82
## Valtio-specific Guideline

##### Documentation

1. Navigate to the [`website`](./website/) folder. (e.g., `cd website`)
2. Install dependencies by running `pnpm install` in the `website` folder
3. Run `pnpm run dev` to start the dev server
4. Navigate to [`http://localhost:3000`](http://localhost:3000) to view the documents
5. Navigate to the [`docs`](./docs/) folder and make necessary changes to the documents.
6. Add your changes to the documents and see them live reloaded in the browser
7. Follow step 4 and onwards from the [General](#General) guide above to bring it to the finish line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overthemike Can you review this section?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

@dai-shi dai-shi merged commit b6118e4 into pmndrs:main Feb 1, 2025
28 checks passed
@sukvvon sukvvon deleted the docs/add-contriuting branch February 2, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants