Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improvements of model geometry settings for the 2d benchmark case 4 #1342

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

keileg
Copy link
Contributor

@keileg keileg commented Feb 18, 2025

Proposed changes

Minor updates to the geometry specification.

Observation: There is no test for this benchmark case. I can add one, but would benefit from a short discussion on how to approach the test.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@IvarStefansson
Copy link
Contributor

Let's discuss in person if you want to add a test.

@keileg keileg force-pushed the fix_benchmark_2d_case_4_geometry branch from b06d21f to d908d0a Compare February 20, 2025 13:11
@keileg keileg merged commit e7bf054 into develop Feb 20, 2025
6 checks passed
@keileg keileg deleted the fix_benchmark_2d_case_4_geometry branch February 20, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants