Fix more compiler warnings

plugdata-team · Feb 13, 2025 · 4cd9bd4 · 4cd9bd4
1 parent 21de5f9
commit 4cd9bd4
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 15 deletions.
diff --git a/Source/CanvasViewport.h b/Source/CanvasViewport.h
@@ -43,8 +43,8 @@ class Minimap : public Component
         }
 
         auto showMinimap = SettingsFile::getInstance()->getProperty<int>("show_minimap");
-        float fadedIn;
-        float fadedOut;
+        float fadedIn = 0.0f;
+        float fadedOut = 0.0f;
         if (showMinimap == 1) {
             fadedIn = 0.0f;
             fadedOut = 0.0f;

diff --git a/Source/Components/MarkupDisplay.h b/Source/Components/MarkupDisplay.h
@@ -273,7 +273,7 @@ class Block : public Component {
                     int const tidx = line.indexOf("<");
                     Colour nextColour = currentColour;
                     String nextLink;
-                    if (bidx > -1 && bidx < iidx | iidx == -1 && bidx < tidx | tidx == -1) {
+                    if ((bidx > -1 && bidx < iidx) || (iidx == -1 && bidx < tidx) || tidx == -1) {
                         // if the next token is toggling the bold state...
                         // ...first add everything up to the token...
                         auto linkText = line.substring(0, bidx);
@@ -283,7 +283,7 @@ class Block : public Component {
                         line = line.substring(bidx + 1); // ...then drop up to and including the token...
                         bold = !bold;                    // ...toggle the bold status...
                         needsNewFont = true;             // ...and request new font.
-                    } else if (iidx > -1 && iidx < tidx | tidx == -1) {
+                    } else if ((iidx > -1 && iidx < tidx) || tidx == -1) {
                         // if the next token is toggling the italic state...
                         // ...first add everything up to the token...
                         auto linkText = line.substring(0, iidx);
@@ -1108,7 +1108,7 @@ class MarkupDisplayComponent final : public Component {
             String line = lines[li];
             if (line.contains("```")) {
                 StringArray clines;
-                if (auto const multiLine = line.lastIndexOf("```") == line.indexOf("```")) {
+                if (line.lastIndexOf("```") == line.indexOf("```")) {
                     do {
                         clines.add(lines[li].replace("```", ""));
                     } while (++li < lines.size() && !lines[li].contains("```"));

diff --git a/Source/Heavy/DaisyExporter.h b/Source/Heavy/DaisyExporter.h
@@ -432,7 +432,7 @@ class DaisyExporter final : public ExporterBase {
 
                     Toolchain runTest;
                     auto output = runTest.startShellScriptWithOutput(testBootloaderScript);
-                    if (bool bootloaderNotFound = output.contains("alt=1")) {
+                    if (output.contains("alt=1")) {
                         exportingView->logToConsole("Bootloader not found...\n");
                         bootloaderExitCode = flashBootloader(bin, sourceDir, make, gccPath);
                     } else {

diff --git a/Source/Iolet.cpp b/Source/Iolet.cpp
@@ -265,7 +265,7 @@ void Iolet::createConnection()
             bool const sameDirection = isInlet == c->getIolet()->isInlet;
 
             // Create new connection if allowed
-            if (bool const connectionAllowed = c->getIolet() != this && c->getIolet()->object != object && !sameDirection) {
+            if (c->getIolet() != this && c->getIolet()->object != object && !sameDirection) {
 
                 auto const outlet = isInlet ? c->getIolet() : this;
                 auto const inlet = isInlet ? this : c->getIolet();

diff --git a/Source/Objects/DropzoneObject.h b/Source/Objects/DropzoneObject.h
@@ -136,7 +136,7 @@ class DropzoneObject final : public ObjectBase, public FileDragAndDropTarget, pu
         auto bounds = getPdBounds();
         auto* patch = cnv->patch.getRawPointer();
         char cnvName[32];
-        snprintf(cnvName, 32, ".x%lx", glist_getcanvas(patch));
+        snprintf(cnvName, 32, ".x%lx", reinterpret_cast<unsigned long>(glist_getcanvas(patch)));
         if (auto gobj = ptr.get<t_gobj>()) {
             pd->sendMessage("__else_dnd_rcv", "_drag_over", { pd->generateSymbol(cnvName), x + bounds.getX(), y + bounds.getY() });
         }
@@ -155,7 +155,7 @@ class DropzoneObject final : public ObjectBase, public FileDragAndDropTarget, pu
         {
             auto* patch = cnv->patch.getRawPointer();
             char cnvName[32];
-            snprintf(cnvName, 32, ".x%lx", (uint64_t)glist_getcanvas(patch));
+            snprintf(cnvName, 32, ".x%lx", reinterpret_cast<unsigned long>(glist_getcanvas(patch)));
             if (auto gobj = ptr.get<t_gobj>()) {
                 pd->sendMessage("__else_dnd_rcv", "_drag_drop", { pd->generateSymbol(cnvName), 0.0f, pd->generateSymbol(file.replace("\\", "/")) });
             }
@@ -177,7 +177,7 @@ class DropzoneObject final : public ObjectBase, public FileDragAndDropTarget, pu
         auto bounds = getPdBounds();
         auto* patch = cnv->patch.getRawPointer();
         char cnvName[32];
-        snprintf(cnvName, 32, ".x%lx", (uint64_t)glist_getcanvas(patch));
+        snprintf(cnvName, 32, ".x%lx", reinterpret_cast<unsigned long>(glist_getcanvas(patch)));
         if (auto gobj = ptr.get<t_gobj>()) {
             pd->sendMessage("__else_dnd_rcv", "_drag_over", { pd->generateSymbol(cnvName), x + bounds.getX(), y + bounds.getY() });
         }
@@ -194,7 +194,7 @@ class DropzoneObject final : public ObjectBase, public FileDragAndDropTarget, pu
     void textDropped (const String& text, int x, int y) override {
         auto* patch = cnv->patch.getRawPointer();
         char cnvName[32];
-        snprintf(cnvName, 32, ".x%lx", (uint64_t)glist_getcanvas(patch));
+        snprintf(cnvName, 32, ".x%lx", reinterpret_cast<unsigned long>(glist_getcanvas(patch)));
         if (auto gobj = ptr.get<t_gobj>()) {
             pd->sendMessage("__else_dnd_rcv", "_drag_drop", { pd->generateSymbol(cnvName), 1.0f, pd->generateSymbol(text) });
         }

diff --git a/Source/Pd/Instance.cpp b/Source/Pd/Instance.cpp
@@ -189,7 +189,6 @@ void Instance::initialisePd(String& pdlua_version)
     pluginLatencyReceiver = pd::Setup::createReceiver(this, "latency_compensation", reinterpret_cast<t_plugdata_banghook>(internal::instance_multi_bang), reinterpret_cast<t_plugdata_floathook>(internal::instance_multi_float), reinterpret_cast<t_plugdata_symbolhook>(internal::instance_multi_symbol),
         reinterpret_cast<t_plugdata_listhook>(internal::instance_multi_list), reinterpret_cast<t_plugdata_messagehook>(internal::instance_multi_message));
 
-    // JYG added This
     dataBufferReceiver = pd::Setup::createReceiver(this, "to_daw_databuffer", reinterpret_cast<t_plugdata_banghook>(internal::instance_multi_bang), reinterpret_cast<t_plugdata_floathook>(internal::instance_multi_float), reinterpret_cast<t_plugdata_symbolhook>(internal::instance_multi_symbol),
         reinterpret_cast<t_plugdata_listhook>(internal::instance_multi_list), reinterpret_cast<t_plugdata_messagehook>(internal::instance_multi_message));
 
@@ -865,7 +864,7 @@ void Instance::handleAsyncUpdate()
     Message mess;
     while (guiMessageQueue.try_dequeue(mess)) {
 
-        switch (auto const dest = hash(mess.destination)) {
+        switch (hash(mess.destination)) {
         case hash("pd"):
             receiveSysMessage(mess.selector, mess.list);
             break;
@@ -929,7 +928,6 @@ void Instance::handleAsyncUpdate()
                 performParameterChange(1, name, state);
             }
             break;
-            // JYG added this
         case hash("to_daw_databuffer"):
             fillDataBuffer(mess.list);
             break;

diff --git a/Source/Pd/Instance.h b/Source/Pd/Instance.h
@@ -272,7 +272,6 @@ class Instance : public AsyncUpdater {
 
     virtual void performLatencyCompensationChange(float value) = 0;
 
-    // JYG added this
     virtual void fillDataBuffer(SmallArray<pd::Atom> const& list) = 0;
     virtual void parseDataBuffer(XmlElement const& xml) = 0;