-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action for mirroring demo container images #1914
Merged
vihangm
merged 8 commits into
pixie-io:main
from
ddelnano:ddelnano/mirror-pixie-demos-images-to-ghcr.io
May 26, 2024
Merged
Add GitHub action for mirroring demo container images #1914
vihangm
merged 8 commits into
pixie-io:main
from
ddelnano:ddelnano/mirror-pixie-demos-images-to-ghcr.io
May 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihangm
reviewed
May 23, 2024
ddelnano
commented
May 23, 2024
Signed-off-by: Dom Del Nano <[email protected]>
…ed with an associative array Signed-off-by: Dom Del Nano <[email protected]>
…y run mode for testing Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
container image namespacing in regbot configuration for demos Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Vihang Mehta <[email protected]>
vihangm
force-pushed
the
ddelnano/mirror-pixie-demos-images-to-ghcr.io
branch
from
May 25, 2024 01:43
bee9eee
to
90d2490
Compare
vihangm
approved these changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the prefix logic, lgtm now!
Signed-off-by: Dom Del Nano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add GitHub action for mirroring demo container images
Relevant Issues: Precursor to fixing px-sock-shop (#1905)
Type of change: /kind bug
Test Plan: Used regbot dry run to verify the following conditions
regbot_demos.yaml
script runs successfully and namespaces each image with demo namecommand output
regbot_deps.yaml
script has same target image uploads during dry run