Upgrade bcc and libbpf to fix Google COS socket tracer issues #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/upgrade-bcc-and-libbpf-to-fix-COS-issue
branch
from
022cc3c
to
21f4736
Compare
ddelnano
commented
May 17, 2024
| urls = [ | ||
| "https://github.com/libbpf/libbpf/archive/refs/tags/v1.0.1.tar.gz", | ||
| "https://github.com/libbpf/libbpf/archive/3b0973892891744d20ae79e99c0d1a26a59c4222.tar.gz", |
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/upgrade-bcc-and-libbpf-to-fix-COS-issue
branch
from
21f4736
to
30fc826
Compare
ddelnano
commented
May 17, 2024
| @@ -68,7 +68,8 @@ TEST(BCCSymbolizer, ModuleName) { | |||
| for (const auto& entry : smaps) { | |||
| if (entry.pathname == "[vdso]") { | |||
| const std::string_view symbol = symbolizer.SymbolOrAddrIfUnknown(pid, entry.vmem_start); | |||
| EXPECT_EQ(symbol, "[m] [vdso] + 0x00000000"); | |||
| const std::string expected = absl::StrCat("[m] [vdso] + 0x", absl::Hex(entry.vmem_start)); | |||
| EXPECT_EQ(symbol, expected); | |||
There was a problem hiding this comment.
iovisor/bcc#4319 provides better symbolization and is the source of this behavior change. I verified this by reverting the change and seeing if the previous version of the test succeeded.
Signed-off-by: Dom Del Nano <[email protected]>
vihangm
approved these changes
May 18, 2024
There was a problem hiding this comment.
Looks ok to me but maybe get @JamesMBartlett or @oazizi000 take a quick pass at it too.
JamesMBartlett
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade bcc and libbpf to fix Google COS socket tracer issues
See GitHub issue comments below for more details. This pulls in the following BCC fix (iovisor/bcc@57ca51b).
Relevant Issues: Closes #1900, part of #1905
Type of change: /kind bug
Test Plan: Skaffold'ed this change to a Ubuntu and Google COS cluster and verified socket tracer works again
Changelog Message: Fix issue with socket tracer on recent Google COS instances