br/stream: implement pause v2 #59663
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59663 +/- ##
================================================
+ Coverage 72.9978% 74.4863% +1.4884%
================================================
Files 1694 1715 +21
Lines 468330 475596 +7266
================================================
+ Hits 341871 354254 +12383
+ Misses 105420 99360 -6060
- Partials 21039 21982 +943
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // OperatorHostName is the hostname that pauses the task. | ||
| OperatorHostName string `json:"operation_hostname"` | ||
| // OperatorPID is the pid of the operator process. | ||
| OperatorPID int `json:"operation_pid"` |
There was a problem hiding this comment.
Why do we need to record the pid?
There was a problem hiding this comment.
Just to distunglish two commands from the same host.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RidRisR The full list of commands accepted by this bot can be found here. |
[LGTM Timeline notifier]Timeline:
|
| @@ -19,6 +24,139 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| const ( | |||
| SeverityError = "ERROR" | |||
There was a problem hiding this comment.
what do you think of replacing Severity to be Reason and REGULAR_OPERATION to be MANUAL
There was a problem hiding this comment.
LGTM, and the TiKV side will be implemented later.
| } | ||
|
|
||
| type TaskPrinter interface { | ||
| AddTask(t TaskStatus) | ||
| PrintTasks() | ||
| } | ||
|
|
||
| func TeeTaskPrinter(p TaskPrinter, output *[]TaskStatus) TaskPrinter { |
There was a problem hiding this comment.
what does Tee mean here?
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
|
/test pull-br-integration-test |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@YuJuncen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #59660
Problem Summary:
See the issue. Breifly say, we need more information of pausing for troubleshooting.
What changed and how does it work?
When pausing, more information was added.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.