Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workloadrepo: make sure WORKLOAD_SCHEMA is ignored by BR #58878

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

workloadrepo: make sure WORKLOAD_SCHEMA is ignored by BR #58878

wants to merge 3 commits into from
+55 −26

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jan 13, 2025

What problem does this PR solve?

Issue Number: close #58768

Problem Summary:

Add WORKLOAD_SCHEMA schema to the ignore list of BR when performing the restore.

BTW, For the 'full backup' process, BR tries to backup everything so there's no mechanism to skip a specific table/schema.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • NA

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.6299%. Comparing base (b7e9769) to head (80e39ea).
Report is 57 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58878        +/-   ##
================================================
+ Coverage   72.9819%   75.6299%   +2.6480%     
================================================
  Files          1693       1742        +49     
  Lines        467972     485362     +17390     
================================================
+ Hits         341535     367079     +25544     
+ Misses       105410      95904      -9506     
- Partials      21027      22379      +1352
Flag Coverage Δ
integration 49.8278% <37.5000%> (?)
unit 73.0791% <68.7500%> (+0.9207%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.0864% <57.1428%> (+16.6180%) ⬆️

@hawkingrei
Copy link
Member

/test all

wddevries
wddevries reviewed Jan 16, 2025
View reviewed changes
pkg/util/workloadrepo/const.go Outdated
Comment on lines 39 to 41
WorkloadSchema = "WORKLOAD_SCHEMA"
// WorkloadSchemaL is the name of database in lower case.
WorkloadSchemaL = "workload_schema"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just make WorkloadSchema lowercase and change the table names to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved WorkloadSchemaL to parser/mysql/const.go and kept this file unchanged.

@bb7133
Copy link
Member Author

bb7133 commented Feb 10, 2025

/retest

@bb7133 bb7133 force-pushed the bb7133/fix_br branch 2 times, most recently from 111feec to cba1a39 Compare February 10, 2025 22:00
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025
@xhebox
Copy link
Contributor

xhebox commented Feb 11, 2025

there is still one failed test

  • check_not_contains workload_schema

TEST FAILED: OUTPUT CONTAINS 'workload_schema'

[Tue Feb 11 06:13:40 CST 2025] Executing SQL: SELECT SCHEMA_NAME FROM information_schema.schemata WHERE SCHEMA_NAME = 'workload_schema';

@bb7133
Copy link
Member Author

bb7133 commented Feb 12, 2025

/retest

@bb7133
Copy link
Member Author

bb7133 commented Feb 12, 2025

there is still one failed test

  • check_not_contains workload_schema

TEST FAILED: OUTPUT CONTAINS 'workload_schema'

[Tue Feb 11 06:13:40 CST 2025] Executing SQL: SELECT SCHEMA_NAME FROM information_schema.schemata WHERE SCHEMA_NAME = 'workload_schema';

@xhebox Thanks, I was working on this failed test...it turns out to be a trap of the check_contains script.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 15, 2025

@wddevries: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3pointer
3pointer reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BR part LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 18, 2025

@yudongusa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037
Benjamin2037 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 07:21:32.749166655 +0000 UTC m=+341135.145388717: ☑️ agreed by xhebox.
  • 2025-02-18 06:43:36.811753226 +0000 UTC m=+943659.207975288: ☑️ agreed by Benjamin2037.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 20, 2025 •
edited
Loading

@bb7133 please approval the pkg/parser scope by yourself with comment /approve.

bb7133
bb7133 commented Feb 20, 2025
View reviewed changes
Copy link
Member Author

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member Author

bb7133 commented Feb 20, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, bb7133, Benjamin2037, wddevries, xhebox, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 20, 2025
@bb7133
Copy link
Member Author

bb7133 commented Feb 21, 2025

/retest

1 similar comment
@xhebox
Copy link
Contributor

xhebox commented Feb 21, 2025

/retest

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@bb7133: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 80e39ea link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wddevries wddevries wddevries approved these changes

@xhebox xhebox xhebox approved these changes

@3pointer 3pointer 3pointer approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@yudongusa yudongusa yudongusa approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workloadrepo: when WORKLOAD_SCHEMA exists, BR failed to ignore it
8 participants
@bb7133 @hawkingrei @xhebox @wuhuizuo @wddevries @3pointer @Benjamin2037 @yudongusa