fix: indent guides causes 1px drift in word wrapped lines #2111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported that deeply indented HTML elements caused misalignment between the text inside elements and their corresponding tags. The issue worsened as indentation depth increased, resulting in a noticeable shift of approximately one or two spaces at deep indentation levels.
Closes
Fixes https://github.com/orgs/phcode-dev/discussions/2108
Root Cause
Previously, the
.cm-phcode-indent-guides::before
selector was used to create indent guides via aborder-left
:However, this approach added a 1px tax per indentation level, meaning that each additional indent slightly shifted the text outward. The cumulative effect of this offset became more noticeable with deeper indentation.
Fix
Replaced the
border-left
approach with an insetbox-shadow
, which does not affect inline layout calculations but still visually maintains the indentation guides:This ensures:
Testing