Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): update types & point to the correct declaration file #954

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

martonlederer
Copy link
Collaborator

This PR aims to fix the out of date typings in @permaweb/ao-loader and updates the package.json file to refer to the correct declaration file.

Fixes: #873 #593

Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

#593 is to do with exporting types in aoconnect, so separate from aoloader. But #873 is this, precisely. Thanks @martonlederer

@TillaTheHun0 TillaTheHun0 merged commit d913d35 into permaweb:main Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ao-loader): update JSDoc on AoLoader parameters, so as to generate correct TS types.
2 participants