fix: In the event of having no authorities on the list, trust no-one. #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the default AOS behavior is now to add an authority explicitly while starting a process, there is still never a reason to make processes trust everyone in absence of an authority.
For all functional purposes, a process may as well be 'dead' than open for all to access. At some point perhaps a warning/confirmation method should be implemented if the user removes the last authority? But this should be carefully thought through.
For now, this code pattern is already being accidentally copied into other implementations (see the recent cpp dev-cli library), so let's remove the potential for danger from the 'reference' implementation.