fix(cu): transfer memory between worker and main thread #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with ArrayBuffers piling up in the heap. Need to figure out if there's a place where an ArrayBuffer out to be dereferenced and subsequently garbage collected. |
|
See #837 for memory leak fix. This PR should hold until that one is merged. |
TillaTheHun0
force-pushed
the
tillathehun0/cu-transfer-memory
branch
4 times, most recently
from
344b74e to
f047ea9
Compare
TillaTheHun0
force-pushed
the
tillathehun0/cu-transfer-memory
branch
4 times, most recently
from
8af0b33 to
f7ce814
Compare
TillaTheHun0
force-pushed
the
tillathehun0/cu-transfer-memory
branch
from
f7ce814 to
aec5aaa
Compare
… threads to prevent truncation
TillaTheHun0
force-pushed
the
tillathehun0/cu-transfer-memory
branch
from
aec5aaa to
4b17762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the CU will transfer the ArrayBuffer representing an ao process' memory between the main thread and worker thread. This in lieu of a structured clone being performed on the ArrayBuffer across threads -- the default behavior of comms via a MessageChannel.
This should reduce the evaluation times for all processes, but particularly processes with large memory foot prints. Additionally, this also circumvents an existing NodeJS bug that prevent structured cloning an ArrayBuffer >4GB.