Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ur): do not parse body on root mu POST route, if request is an assignment #697 #703

Merged
merged 1 commit into from
May 21, 2024

Conversation

TillaTheHun0
Copy link
Member

@TillaTheHun0 TillaTheHun0 commented May 12, 2024

This PR makes it so that the MU route will conditionally consume the body based on whether or not the assign query parameter is provided. In this case, there is no body to consume. Additionally, the processId is available as a process-id query parameter, and so can be extracted from there.

@TillaTheHun0 TillaTheHun0 requested a review from VinceJuliano May 12, 2024 19:48
Copy link
Collaborator

@VinceJuliano VinceJuliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TillaTheHun0 TillaTheHun0 merged commit 2e20820 into main May 21, 2024
2 checks passed
@TillaTheHun0 TillaTheHun0 deleted the tillathehun0/ur-conditional-mu-assign branch May 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants