Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add monitor method to connect #312 #313

Merged
merged 2 commits into from
Jan 12, 2024
Merged

feat: add monitor method to connect #312 #313

merged 2 commits into from
Jan 12, 2024

Conversation

twilson63
Copy link
Contributor

No description provided.

TillaTheHun0
TillaTheHun0 reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But it looks like the business logic is missing in lib/monitor/index.js

I think I can fill in the blanks.

connect/src/index.common.js Show resolved Hide resolved
TillaTheHun0
TillaTheHun0 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@TillaTheHun0 TillaTheHun0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i'd like to wrap the side effect in a zod schema, but I can do that separately once it's merged. But this LGTM!

@TillaTheHun0 TillaTheHun0 merged commit 1ccb6cf into main Jan 12, 2024
2 checks passed
@TillaTheHun0 TillaTheHun0 deleted the twilson63/feat-connect-add-monitor-312 branch January 12, 2024 21:10
@TillaTheHun0 TillaTheHun0 linked an issue Jan 12, 2024 that may be closed by this pull request
feat(connect): add monitor method to the connect library #312
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TillaTheHun0 TillaTheHun0 TillaTheHun0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(connect): add monitor method to the connect library
2 participants
@twilson63 @TillaTheHun0