Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cu): prevent stuck stream by destroying all and bubbling error #1138

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(cu): prevent stuck stream by destroying all and bubbling error #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions servers/cu/src/domain/lib/evaluate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,24 +281,28 @@ export function evaluateWith (env) {
* THEN we add an error listener such that any stream erroring
* results in all streams being cleaned up and destroyed with that error.
*
* Finally, if an error was thrown from any stream, we re-throw such that the eval promise rejects,
* bubbling the error to the caller
* Finally, if an error was thrown from any stream, we reject a top level promise that
* then triggers Promise.race to also reject, bubbling the error
*/
if (!Array.isArray(ctx.messages)) ctx.messages = [ctx.messages]
const streams = [...ctx.messages, removeInvalidTags]
streams.push(composeStreams(...streams))
let e
const { promise: bailout, resolve: pResolve, reject: pReject } = Promise.withResolvers()
streams.forEach(s => {
s.on('error', (err) => {
e = err
streams.forEach(s => {
s.emit('end')
s.destroy(err)
setImmediate(() => s.removeAllListeners())
})

pReject(err)
})
})
await pipeline(streams[streams.length - 1], evalStream)
if (e) throw e
await Promise.race([
pipeline(streams[streams.length - 1], evalStream).then(pResolve),
bailout
])

/**
* Make sure to attempt to cache the last result
Expand Down