-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support building AO wasm module with Rust code #1122
Open
RyanKung
wants to merge
19
commits into
permaweb:main
Choose a base branch
from
RyanKung:feat_rust_impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update, we now have issues: [wasm-validator error in function _$LT$$RF$T$u20$as$u20$core..fmt..Debug$GT$::fmt::hea3ded4c73476728] i64 != i32: indirect call target must be an i32, on
(call_indirect $0 (type $func.0)
(i64.load
(local.get $0)
)
(local.get $1)
(i64.load offset=24
(i64.load offset=8
(local.get $0)
)
)
) Looks like the call_indirect of |
Fixed by set target=32 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
It implements the functionality of compiling Rust code into the AO_WASM-compatible format. The principle is to use FFI to bridge Rust and C, allowing C code to directly call Rust and enabling compilation into WASM within a Docker image.
Note: This PR is based on the following PRs.
#1121
#1119
This PR has not undergone comprehensive testing. If you wanna to try it out, please carefully review the relevant code. If you encounter any issues, feel free to make modifications based on this branch.
How to use
At
ao/dev-cli/container
:Run
bash.sh
to build your custom ImageAt
src/starters/rust
Run
ao build --image docker.io/p3rmaw3b/ao
to build.Key features / changes:
cmd.extend(['-I/opt/aorustlib', '-L/opt/aorustlib', '-laorust'])
/src
, then move headers and staticlib to '/opt/aorustlib'