-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a docker-compose based testing method #4121
base: master
Are you sure you want to change the base?
Introduce a docker-compose based testing method #4121
Conversation
Cool, this also allows for reproducing the whole deployment. |
I've pushed a quick update which increases the |
Thank you @TallTed for your suggestions, I've committed them all 👍 |
Hi 👋 Does this PR need some more work before being approved ? |
@davidlehn any thoughts? |
This looks nice. Thanks. I've been a bit busy to test it out properly. Will try to soon.
|
Co-authored-by: Ted Thibodeau Jr <[email protected]>
49909cc
to
1d79848
Compare
@davidlehn I've just rebased my branch and took into account your first and last comment. I'm not sure I'm the best person to voice an opinion about your second comment as I don't know how you deploy this project 😇 |
Hi 👋 Can someone review this pull request as it is opened for a while now ? 😇 |
Hi @davidlehn The changes are quite light and can be used by many to validate their configuration. |
Hi 👋
As I've been working on this project recently, I noticed that there wasn't any unified testing method for identifiers and this has been mentioned in issues such as #2258.
This pull request is a proposal for a simple and straightforward testing method based on
docker-compose
to run the official Apache httpd Docker image. This uses anhttpd.conf
file that is just the original configuration file with the rewrite engine enabled andAllowOverride All
for the main directory.I've also updated the README to add explanations on how to test identifiers 😊