ci: fix publish step check before tagging

[ctran88]

What's New?

fromJSON was unable to parse the value of steps.publish-crates.outputs.published, so this change uses an alternative value to check for publication success.

Screenshots (if appropriate):

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have manually tested my code thoroughly
• I have added/updated inline documentation for public facing interfaces if relevant
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing integration and unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Additional context

[ctran88]

the stringified version of an empty array in JS is just an empty string (not counting however @actions/core decides to serialize the value).

given error message from the last successful release, it made it seem like the value was an empty string (Path '', line 0, position 0.) so i wasn't too confident in just checking that.

a failure on the publish step should result in a step failure based on https://github.com/katyo/publish-crates/blob/5e67639f17e8a1f221e804c2bd47f7a253e45dac/src/main.ts#L145

so i figured we could just check for the success of the publish step instead.

[bertrmz]

Did you get a chance to test if this line alone fixes the error? Running actionlint on the main branch flags the missing id for this GitHub Actions step, as it’s used later but isn’t currently defined.

[ctran88]

i did try to check it, but the output was always an empty string, so i couldn't be sure if it would've worked or not with an actual release.

[bertrmz]

The test run here shows fromJSON works when the output includes the array string for a new version. However, if there’s no new version, the output is an empty string, causing fromJSON to fail.

The outcome == 'success' check should work well, but an empty string check could also suffice.

[ctran88]

i think i'll opt to leave it with `outcome == 'success' since it's a bit easier to understand without looking through the action's docs for someone else on our team to work on this in the future. but good to see the output on a successful run as well