feat(primitivies): impl a handful of traits for fixed types #7565
+240
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiintbrisson
force-pushed
the
feat/primitivies/impl-sum-for-fixed-types
branch
3 times, most recently
from
9ea4117 to
85d920e
Compare
saiintbrisson
force-pushed
the
feat/primitivies/impl-sum-for-fixed-types
branch
from
85d920e to
3944b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a handful of traits for fixed types:
sumhelper for iterators,Rem/CheckedRem,Signed/UnsignedandNum,MultiplyArgto be used withPerThing,to_u32to matchto_float.I'd also love to impl forward reference implementations for binops traits (
Add<&Self> for Self,Add<Self> for &Self, etc), but this breaks the existing.into()calls as it turns the conversion ambiguous. Not sure if that's a price you are willing to pay, but would be very much appreciated.