-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridges: Remove obsolete relayer CLI args: host, port, path, secure #7549
Bridges: Remove obsolete relayer CLI args: host, port, path, secure #7549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
We should also take a note in #7291 to update the bridge zombienet tests after a new version of the relayer is published: polkadot-sdk , fellowship/runtimes and also the CI team might need to update the setup for the Polkadot-Kusama relayers.
Also did you run the polkadot-sdk
zombienet tests to make sure that they work with this change ? They don't automatically run in the CI, because in the CI we use an older version of the relayer.
We've checked this already, it uses just
exactly, when we upgrade bridges repo paritytech/parity-bridges-common#3104 + this PR |
@rosarp please update also:
|
remove function run_relay & start-relayer.sh
@rosarp let's wait for |
@rosarp done ontinuous-integration/gitlab-zombienet-bridges-0001-asset-transfer-works |
@rosarp please check and fix this https://github.com/paritytech/polkadot-sdk/actions/runs/13388860894/job/37398961863?pr=7549#step:4:4937
|
Pull Request is not mergeable
5c9fda5
…aritytech#7549) Closes: paritytech#7291 ## Description *Removes obsolete relayer CLI args from bridges and resolves following issue: (paritytech#7291 --------- Co-authored-by: Branislav Kontur <[email protected]>
Closes: #7291
Description
Removes obsolete relayer CLI args from bridges and resolves following issue: (#7291)