-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fatxpool
: event streams moved to view domain
#7545
base: master
Are you sure you want to change the base?
Conversation
All GitHub workflows were cancelled due to failure one of the required jobs. |
/cmd prdoc --bump minor --audience node_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just the one comment needs to be addressed.
Overview
This pull request refactors the transaction pool
graph
module by renaming components for better clarity. TheEventHandler
trait was introduced to enhance flexibility in handling transaction lifecycle events. Changes include renaminggraph::Listener
tograph::EventDispatcher
and moving certain functionalities fromgraph
toview
module in order to decouplegraph
fromview
-related specifics.This PR does not introduce changes in the logic.
Notes for Reviewers
All the changes looks dense at first, but in fact following was done:
graph::Listener
was renamed tograph::EventDispatcher
, to better reflect its role in dispatching transaction-related events fromValidatedPool
. TheEventDispatcher
now utilizes theL: EventHandler
generic type to handle transaction status events.EventHandler
trait was introduced to handle transaction lifecycle events, improving implementation flexibility and providing clearer role descriptions within the system. Introduction of this trait allowed the removal ofView
related entities (e.g. streams) from theValidatedPool
's event dispatcher (previously listener).graph::listener
to theview
module. TheViewPoolObserver
, which implementsEventHandler
, now provides the implementation of streams feeding.listener
were renamed toevent_dispatcher
to align with their purpose and type naming.Pool
andValidatedPool
were updated to include a genericL: EventHandler
across the codebase.