Trying to fix Issue #775 #808
Conversation
trying to fix the Topic import bug
NaorisKong
requested review from
paolosalvatori,
SeanFeldman and
ErikMogensen
as code owners
| ruleFilter = new CorrelationFilter(propertyValue[CorrelationId] as string); | ||
| ruleFilter = new CorrelationFilter() | ||
| { | ||
| ContentType = !string.IsNullOrWhiteSpace(propertyValue[ContentType] as string) ? propertyValue[ContentType] as string : null, |
There was a problem hiding this comment.
Question: is it necessary to use ternary condition if it's either a value or a null? Could this (one example) be it?
ContentType = propertyValue[ContentType] as string,
There was a problem hiding this comment.
If use the code
ContentType = propertyValue[ContentType] as string
May cause the exception "Exception: The argument contentType is null or white space."
Because when the xml be like this <ContentType></ContentType>, use propertyValue[ContentType] will get a empty string and I guess the construction function of CorrelationFilter can`t accept a empty string.
There was a problem hiding this comment.
Indeed. This is to avoid empty string. Thank you for elaboration. In that case, could you make it a local function and pass the property name? On the local function you could put XML documentation or a comment elaborating the rationale. Thank you.
There was a problem hiding this comment.
Ok, I will try to create a function to deal with it and add some comments.
There was a problem hiding this comment.
Added a extension method on Dictionary<string, object>.Think it`s cleaner.
| /// <summary> | ||
| /// this exthension method is used to get the string value from the dictionary | ||
| /// if the value is null or empty then it will return null | ||
| /// </summary> | ||
| /// <param name="propertyValue"></param> | ||
| /// <param name="propertyName"></param> | ||
| /// <returns></returns> |
There was a problem hiding this comment.
| /// <summary> | |
| /// this exthension method is used to get the string value from the dictionary | |
| /// if the value is null or empty then it will return null | |
| /// </summary> | |
| /// <param name="propertyValue"></param> | |
| /// <param name="propertyName"></param> | |
| /// <returns></returns> | |
| /// <summary> | |
| /// Get the string value from the dictionary. Return null when the value is null or empty. | |
| /// </summary> |
fix #775
Trying to fix the Topic import bug.
Added const string of correlation filter name.
Added CorrelationFilter initialization logic in CreateFilter function.