Revert the High DPI changes #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
SeanFeldman
reviewed
Nov 4, 2024
src/Common/Common.csproj
Outdated
| @@ -3,7 +3,7 @@ | |||
| <ProjectGuid>{DE07DBEB-D772-49BA-BCEB-A7CE29308AE3}</ProjectGuid> | |||
| <RootNamespace>ServiceBusExplorer.Common</RootNamespace> | |||
| <AssemblyName>ServiceBusExplorer.Common</AssemblyName> | |||
| <TargetFramework>net472</TargetFramework> | |||
| <TargetFramework>net462</TargetFramework> | |||
There was a problem hiding this comment.
Are there any concerns about reverting the target framework? In theory, this change shouldn't impact UI at all.
There was a problem hiding this comment.
There were some changes in the original PR that I would have liked to keep, but to keep it clean and as I am pressed for time I didn't change them. However, I think we should stick to NET 4.7.2 for all NET Framework assemblies, since the XUnit PR may have assemblies that are dependent upon that version.
Hopefully there is a new High DPI PR and that will require 4.7.2 anyways.
How do we handle this?
There was a problem hiding this comment.
I'd say revert everything but the TF. Keep it as net472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #804, there are some GUI things that don't look good after the changes for high DPI. Therefore this change reverts those changes.
Sorry @jmoralesv. I hope you will find the time to get this working for those scenarios.
Second try as the first PR had two commits.