Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection box icons #7239

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Add selection box icons #7239

merged 4 commits into from
Feb 7, 2025

Conversation

tmiskow
Copy link
Contributor

@tmiskow tmiskow commented Feb 6, 2025

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adding three new icons: selection-box, selection-box-add and selection-box-edit

Reviewers should focus on:

  • do new icons satisfy design guidelines?
  • do new icons have relevant names and metadata?

Screenshot

image
image

Credits to @tylerbutton85 for the icons, I am just pushing the PR

@changelog-app
Copy link

changelog-app bot commented Feb 6, 2025

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add selection box icons

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add selection box icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@tylerbutton85
Copy link

do new icons satisfy design guidelines?

@tmiskow These icons have been reviewed and approved for blueprint contribution.

packages/icons/icons.json Outdated Show resolved Hide resolved
resources/icons/16px/selection-box-add.svg Outdated Show resolved Hide resolved
resources/icons/16px/selection-box-edit.svg Outdated Show resolved Hide resolved
resources/icons/16px/selection-box.svg Outdated Show resolved Hide resolved
resources/icons/20px/selection-box-add.svg Outdated Show resolved Hide resolved
resources/icons/20px/selection-box-edit.svg Outdated Show resolved Hide resolved
resources/icons/20px/selection-box.svg Outdated Show resolved Hide resolved
@tmiskow
Copy link
Contributor Author

tmiskow commented Feb 7, 2025

Fixed the icon name and simplified the SVGs 👍

@svc-palantir-github
Copy link

Simplify SVGs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@tmiskow tmiskow merged commit cbdcffd into develop Feb 7, 2025
13 checks passed
@tmiskow tmiskow deleted the tmiskow/add-new-interface-icons branch February 7, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants