Adding a reconnect button for websocket disconnection #70
Conversation
There was a problem hiding this comment.
Good job, Jack!
This looks good to go. As @mmehta2669 pointed out, it'd be nice to have those comments as some form of mild documentation.
One point to note for future implementation is reconnecting disruption that shuts down the server. In such a case we'd need to differentiate between a closed socket connection and an entirely closed server.
| websocket.current.close(); | ||
| console.log("WebSocket connection closed manually."); | ||
| } | ||
|
|
||
| websocket.current = new WebSocket("ws://localhost:8000/ws"); |
There was a problem hiding this comment.
Hard-coding the address is generally a bad idea. Not sure if that's how the project handles it in other places, but a better approach is to define a configuration file and place the server address there.
There was a problem hiding this comment.
I will put this into a separate issue, the fix generates a bunch of connection problems.
Fixes #63
What was changed:
The disconnected banner was changed to add a reconnect button
Why was this changed:
This was changed because the users had no way to reconnect the websocket if the connection was dropped, rendering the app useless.
How was this changed:
I added a button to appear when the websocket disconnected. I changed how the webosckets connect by creating a setup websocket function that can be called more than once