TimecodeField: Now handles on-screen keyboard Return key on iPadOS

orchetect · Oct 11, 2024 · b65a1d2 · b65a1d2
1 parent eb9927e
commit b65a1d2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/Sources/TimecodeKitUI/SwiftUI/TimecodeField/TimecodeField ComponentView.swift b/Sources/TimecodeKitUI/SwiftUI/TimecodeField/TimecodeField ComponentView.swift
@@ -69,9 +69,9 @@ extension TimecodeField {
             #elseif os(iOS) || os(visionOS)
             ZStack {
                 KeyboardInputView(
-                    keyboardType: .decimalPad
+                    keyboardType: .decimalPad // note that on iPadOS this also contains extended chars
                 ) { keyEquivalent in
-                    handleKeyPress(key: keyEquivalent)
+                    _ = handleKeyPress(key: keyEquivalent)
                 }
                 .onKeyPress(phases: [.down, .repeat]) { keyPress in
                     // only handle hardware keyboard keys that aren't already handled by KeyboardInputView.

diff --git a/Sources/TimecodeKitUI/Utilities/KeyboardInputView.swift b/Sources/TimecodeKitUI/Utilities/KeyboardInputView.swift
@@ -124,6 +124,15 @@ struct KeyboardInputView: UIViewRepresentable {
             keyPressed(.delete)
         }
 
+        // forward return key
+        func textFieldShouldReturn(_ textField: UITextField) -> Bool {
+            keyPressed(.return)
+            return false
+        }
+
+        // TODO: could forward this in the future as well
+        // func textFieldShouldClear(_ textField: UITextField) -> Bool { }
+
         override var hasText: Bool { true }
     }
 }