improve: logging for informers (#1753)

operator-framework · Feb 3, 2023 · 6e224d4 · 6e224d4
1 parent cd46b28
commit 6e224d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...k-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java b/...k-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java
@@ -98,12 +98,14 @@ public synchronized void stop() {
   @SuppressWarnings("rawtypes")
   private void logEventSourceEvent(NamedEventSource eventSource, String event) {
     if (log.isDebugEnabled()) {
-      if (eventSource instanceof ResourceEventSource) {
-        ResourceEventSource source = (ResourceEventSource) eventSource;
-        log.debug("{} event source {} for {}", event, eventSource.name(),
+      if (eventSource.original() instanceof ResourceEventSource) {
+        ResourceEventSource source = (ResourceEventSource) eventSource.original();
+        log.debug("{} event source {} for {}", event,
+            eventSource.isNameSet() ? eventSource.name() : eventSource,
             source.resourceType());
       } else {
-        log.debug("{} event source {}", event, eventSource.name());
+        log.debug("{} event source {}", event,
+            eventSource.isNameSet() ? eventSource.name() : eventSource);
       }
     }
   }

diff --git a/...ork-core/src/main/java/io/javaoperatorsdk/operator/processing/event/NamedEventSource.java b/...ork-core/src/main/java/io/javaoperatorsdk/operator/processing/event/NamedEventSource.java
@@ -72,7 +72,7 @@ public EventSource eventSource() {
 
   @Override
   public String toString() {
-    return original + " named: '" + name + "'}";
+    return original + " named: " + name;
   }
 
   public EventSource original() {